Peer Code Review
You will be paired with one person from a different group for today’s peer review session.
- Share a link to your github repository.
- Spend 20 minutes to review the other teams’ code. Answer the following questions (write them down to share!)
- Where are they performing the conversion of PriceInCents to PriceInDollars?
- When editing an item, what kind of data is expected in the ‘price’ field? Are there any disadvantages to this datatype? Is there another place this conversion could be made?
- What differences are there in the migration files between their project and yours?
- How is the total spent by customer calculated?
- In reviewing the other group’s code - what questions do you have for them, or for an instructor?
- Was there anything the other group did that made their code easier to understand?
- Were there any sections of the code you found particularly difficult to understand?
- Spend 20 minutes (10 minutes per person) to share your answers to the questions above, and discuss the following:
- What part of this project were you most excited about?
- What part of this project was the most difficult?
- How did your git workflow go?
