Peer Feedback

As with writing an essay, having an outside set of eyes give feedback can be very helpful for improving the quality of the end product. Additionally, reading other people’s code is one of the best ways to level up as a developer!

For these reasons, code review is a key part of working on most development teams and something we will practice starting today.

You will write your notes using this google doc template and then share the doc with your partner.

For part 1, which takes place this afternoon, you and your partner will exchange Github links for your project repos and then independently walk through the Setup section and write usability feedback. We recommend spending 15 to 30 minutes on this portion.

For part 2, which will take place tomorrow morning, you will be in a breakout room with your partner for 40 minutes. Each partner will have 15 minutes to share their screen and talk through the sections of code they would most like feedback on. Make sure to show your tests. The partner giving feedback will ask questions and take notes for the Code Structure, Testing, and Additional Feedback and Notes sections of the google doc. Next, take 5 minutes to share your feedback. Then switch places and repeat the process where the other partner is sharing their screen.

Remember that feedback should be actionable and kind.

Part 1: Complete this portion separately before you meet with your partner tomorrow.

Setup

First,

Clone down your partner’s project. You do not need to fork before cloning. You will need to give the repo a different name when you clone it down so it doesn’t interfere with your project. For example, MessageLoggerZoe.
Run your partner’s project as a user would

Usability

How was your experience figuring out how to use your partner’s project?
Do you have any suggestions for increasing usability?
Did you find any bugs?

Part 2: Complete this portion with your partner.

Code Structure

Are there any areas of code that you found especially easy to understand? Or are there any things your partner did that helped you as someone trying to understand their code?
Are there any other areas of code that you found more difficult to understand?

Testing

Do you have any feedback on the tests your partner wrote?
Are there any other tests you think might be useful for your partner to add?

Other

Any other feedback or questions?